Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Arcane Magnet #3968

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JustAHuman-xD
Copy link
Contributor

Description

This PR adds a new magnet, the Arcane Magnet, it is like the infused magnet except it also teleports Experience

Proposed changes

  • Adjusted some Javadocs of InfusedMagnet and InfusedMagnetTask
  • Created ArcaneMagnet.java and ArcaneMagnetTask.java both follow the style of the corresponding InfusedMagnet.java and InfusedMagnetTask.java
  • Added ARCANE_MAGNET_TELEPORT_SOUND to the SoundEffect enum
  • Added "ARCANE_MAGNET" to the "Infused Magnets" research
  • Changed GadgetsListener#onToggleSneak to have a guard statement at the beginning and also support ArcaneMagnetTask
    • I check for the Arcane magnet first and if its not there then check for the infused magnet, to avoid 2 tasks when the arcane magnet does everything the infused magnet does

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner September 9, 2023 14:48
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@JustAHuman-xD JustAHuman-xD changed the title Implement the Arcane Magnet Add the Arcane Magnet Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5620898e

https://preview-builds.walshy.dev/download/Slimefun/3968/5620898e

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants